Програмиране с Python

Курс във Факултета по Математика и Информатика към СУ

Решение на Морски шах от Илия Ячев

Обратно към всички решения

Към профила на Илия Ячев

Резултати

  • 6 точки от тестове
  • 0 бонус точки
  • 6 точки общо
  • 8 успешни тест(а)
  • 0 неуспешни тест(а)

Код

class TicTacToeBoard:
def __init__(self):
self.board = [' ' for i in range(9)]
self.all_coordinates = [i + str(j) for j in [3, 2, 1]
for i in ['A', 'B', 'C']]
self.status = 'Game in progress.'
self.last_turn = ''
def get_index(self, coordinates):
return self.all_coordinates.index(coordinates)
def __getitem__(self, coordinates):
return self.board[self.get_index(coordinates)]
def __setitem__(self, coordinates, value):
if self.status == 'Game in progress.':
self.check_for_invalid_turn(coordinates, value)
self.board[self.get_index(coordinates)] = value
self.last_turn = value
self.check_for_winning_move(coordinates, value)
self.check_if_board_is_full()
def check_for_invalid_turn(self, coordinates, value):
if coordinates not in self.all_coordinates:
raise InvalidKey('No tile at coordinates {}'.format(coordinates))
if self[coordinates] != ' ':
raise InvalidMove('Tile {} is already taken'.format(coordinates))
if value not in ['X', 'O']:
raise InvalidValue('{} is not valid\nTry X or O'.format(value))
if value == self.last_turn:
raise NotYourTurn('Player {}, it is not your turn'.format(value))
def check_for_winning_move(self, coordinates, value):
index = self.get_index(coordinates)
current_row = self.get_row(index // 3)
current_column = self.get_column(index % 3)
primary_diagonal = self.get_secondary_diagonal()
secondary_diagonal = self.get_primary_diagonal()
possible_winning_lines = [current_row, current_column,
primary_diagonal, secondary_diagonal]
if set(value) in [set(line) for line in possible_winning_lines]:
self.status = "{} wins!".format(value)
def get_row(self, row_index):
return [self.board[i] for i in range(9) if i // 3 == row_index]
def get_column(self, column_index):
return [self.board[i] for i in range(9) if i % 3 == column_index]
def get_primary_diagonal(self):
return [self.board[i] for i in [0, 4, 8]]
def get_secondary_diagonal(self):
return [self.board[i] for i in [2, 4, 6]]
def check_if_board_is_full(self):
if ' ' not in self.board and self.status == 'Game in progress.':
self.status = "Draw!"
def game_status(self):
return self.status
def __str__(self):
lines = ['']
for i in [3, 2, 1]:
lines.append(str(i) + ' | {} | {} | {} |')
lines.append(' A B C \n')
return '\n -------------\n'.join(lines).format(*self.board)
class InvalidKey(Exception):
pass
class InvalidMove(Exception):
pass
class InvalidValue(Exception):
pass
class NotYourTurn(Exception):
pass

Лог от изпълнението

........
----------------------------------------------------------------------
Ran 8 tests in 0.008s

OK

История (2 версии и 1 коментар)

Илия обнови решението на 10.04.2013 18:12 (преди около 11 години)

+class TicTacToeBoard:
+ def __init__(self):
+ self.board = [' ' for i in range(9)]
+ self.all_coordinates = [i + str(j) for j in [3, 2, 1]
+ for i in ['A', 'B', 'C']]
+ self.status = 'Game in progress.'
+ self.turn = ''
+
+ def get_index(self, coordinates):
+ return self.all_coordinates.index(coordinates)
+
+ def __getitem__(self, coordinates):
+ return self.board[self.get_index(coordinates)]
+
+ def make_valid_move(move):
+ def valid_move(self, *args):
+ if self.status == 'Game in progress.':
+ self.check_for_invalid_turn(*args)
+ move(self, *args)
+ self.check_for_winning_move(*args)
+ self.check_if_board_is_full()
+ return valid_move
+
+ @make_valid_move
+ def __setitem__(self, coordinates, value):
+ self.board[self.get_index(coordinates)] = value
+ self.turn = value
+
+ def check_for_invalid_turn(self, coordinates, value):
+ if coordinates not in self.all_coordinates:
+ raise InvalidKey(coordinates)
+ if self[coordinates] != ' ':
+ raise InvalidMove(coordinates)
+ if value not in ['X', 'O']:
+ raise InvalidValue(value)
+ if value == self.turn:
+ raise NotYourTurn(value)
+
+ def check_for_winning_move(self, coordinates, value):
+ index = self.get_index(coordinates)
+ current_row = [self[i] for i in self.all_coordinates if (
+ self.get_index(i) - index) % 3 == 0]
+ current_column = [self[i] for i in self.all_coordinates if (
+ self.get_index(i) // 3 == index // 3)]
+ primary_diagonal = [self.board[i] for i in [0, 4, 8]]
+ secondary_diagonal = [self.board[i] for i in [2, 4, 6]]
+ all_possible_winning_lines = [current_row, current_column,
+ primary_diagonal, secondary_diagonal]
+ if set(value) in [set(line) for line in all_possible_winning_lines]:
+ self.status = "{} wins!".format(value)
+
+ def check_if_board_is_full(self):
+ if ' ' not in self.board and self.status == 'Game in progress.':
+ self.status = "Draw!"
+
+ def game_status(self):
+ return self.status
+
+ def __str__(self):
+ lines = ['']
+ for i in [3, 2, 1]:
+ lines.append(str(i) + ' | {} | {} | {} |')
+ lines.append(' A B C \n')
+ return '\n -------------\n'.join(lines).format(*self.board)
+
+
+class InvalidKey(Exception):
+ def __init__(self, coordinates):
+ self.message = 'No tile at coordinates {}'.format(coordinates)
+
+
+class InvalidMove(Exception):
+ def __init__(self, coordinates):
+ self.message = 'The tile at {} is already taken'.format(coordinates)
+
+
+class InvalidValue(Exception):
+ def __init__(self, value):
+ self.message = 'The value {} is not valid\nTry X or O'.format(value)
+
+
+class NotYourTurn(Exception):
+ def __init__(self, value):
+ self.message = 'Player {}, it is not your turn'.format(value)

Декораторът ти @make_valid_move е абсолютно ненужен в случая и само усложнява решението ти. Като цяло ако направиш декоратор който се използва само веднъж, значи нещо бъркаш.

Освен това е по-добре да дефинираш изключенията ти така:

class InvalidValue(Exception):
    pass

и да ги извикваш така: raise InvalidValue('The value {} is not valid\nTry X or O'.format(value))

__str__ на Exception връща първият аргумент подаден на изключението така че няма нужда от message атрибут.

Илия обнови решението на 10.04.2013 23:53 (преди около 11 години)

class TicTacToeBoard:
def __init__(self):
self.board = [' ' for i in range(9)]
self.all_coordinates = [i + str(j) for j in [3, 2, 1]
for i in ['A', 'B', 'C']]
self.status = 'Game in progress.'
- self.turn = ''
+ self.last_turn = ''
def get_index(self, coordinates):
return self.all_coordinates.index(coordinates)
def __getitem__(self, coordinates):
return self.board[self.get_index(coordinates)]
- def make_valid_move(move):
- def valid_move(self, *args):
- if self.status == 'Game in progress.':
- self.check_for_invalid_turn(*args)
- move(self, *args)
- self.check_for_winning_move(*args)
- self.check_if_board_is_full()
- return valid_move
-
- @make_valid_move
def __setitem__(self, coordinates, value):
- self.board[self.get_index(coordinates)] = value
- self.turn = value
+ if self.status == 'Game in progress.':
+ self.check_for_invalid_turn(coordinates, value)
+ self.board[self.get_index(coordinates)] = value
+ self.last_turn = value
+ self.check_for_winning_move(coordinates, value)
+ self.check_if_board_is_full()
def check_for_invalid_turn(self, coordinates, value):
if coordinates not in self.all_coordinates:
- raise InvalidKey(coordinates)
+ raise InvalidKey('No tile at coordinates {}'.format(coordinates))
if self[coordinates] != ' ':
- raise InvalidMove(coordinates)
+ raise InvalidMove('Tile {} is already taken'.format(coordinates))
if value not in ['X', 'O']:
- raise InvalidValue(value)
- if value == self.turn:
- raise NotYourTurn(value)
+ raise InvalidValue('{} is not valid\nTry X or O'.format(value))
+ if value == self.last_turn:
+ raise NotYourTurn('Player {}, it is not your turn'.format(value))
def check_for_winning_move(self, coordinates, value):
index = self.get_index(coordinates)
- current_row = [self[i] for i in self.all_coordinates if (
- self.get_index(i) - index) % 3 == 0]
- current_column = [self[i] for i in self.all_coordinates if (
- self.get_index(i) // 3 == index // 3)]
- primary_diagonal = [self.board[i] for i in [0, 4, 8]]
- secondary_diagonal = [self.board[i] for i in [2, 4, 6]]
- all_possible_winning_lines = [current_row, current_column,
- primary_diagonal, secondary_diagonal]
- if set(value) in [set(line) for line in all_possible_winning_lines]:
+ current_row = self.get_row(index // 3)
+ current_column = self.get_column(index % 3)
+ primary_diagonal = self.get_secondary_diagonal()
+ secondary_diagonal = self.get_primary_diagonal()
+ possible_winning_lines = [current_row, current_column,
+ primary_diagonal, secondary_diagonal]
+ if set(value) in [set(line) for line in possible_winning_lines]:
self.status = "{} wins!".format(value)
+ def get_row(self, row_index):
+ return [self.board[i] for i in range(9) if i // 3 == row_index]
+
+ def get_column(self, column_index):
+ return [self.board[i] for i in range(9) if i % 3 == column_index]
+
+ def get_primary_diagonal(self):
+ return [self.board[i] for i in [0, 4, 8]]
+
+ def get_secondary_diagonal(self):
+ return [self.board[i] for i in [2, 4, 6]]
+
def check_if_board_is_full(self):
if ' ' not in self.board and self.status == 'Game in progress.':
self.status = "Draw!"
def game_status(self):
return self.status
def __str__(self):
lines = ['']
for i in [3, 2, 1]:
lines.append(str(i) + ' | {} | {} | {} |')
lines.append(' A B C \n')
return '\n -------------\n'.join(lines).format(*self.board)
class InvalidKey(Exception):
- def __init__(self, coordinates):
- self.message = 'No tile at coordinates {}'.format(coordinates)
+ pass
class InvalidMove(Exception):
- def __init__(self, coordinates):
- self.message = 'The tile at {} is already taken'.format(coordinates)
+ pass
class InvalidValue(Exception):
- def __init__(self, value):
- self.message = 'The value {} is not valid\nTry X or O'.format(value)
+ pass
class NotYourTurn(Exception):
- def __init__(self, value):
- self.message = 'Player {}, it is not your turn'.format(value)
+ pass